Re: [PATCH v7 03/14] net: phy: at803x: add QCA8084 ethernet phy support

[Jie Luo]

On 12/14/2023 7:01 PM, Andrew Lunn wrote:
> On Thu, Dec 14, 2023 at 05:48:02PM +0800, Luo Jie wrote:
> > Add qca8084 PHY support, which is four-port PHY with maximum
> > link capability 2.5G, the features of each port is almost same
> > as QCA8081 and slave seed config is not needed.
> >
> > Three kind of interface modes supported by qca8084.
> > PHY_INTERFACE_MODE_10G_QXGMII, PHY_INTERFACE_MODE_2500BASEX and
> > PHY_INTERFACE_MODE_SGMII.
> >
> > The PCS(serdes) and clock are also needed to be configured to
> > bringup qca8084 PHY, which will be added in the pcs driver.
> >
> > The additional CDT configurations used for qca8084.
> >
> > Signed-off-by: Luo Jie <quic_luoj@xxxxxxxxxxx>
> > ---
> >   drivers/net/phy/at803x.c | 49 ++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 49 insertions(+)
> >
> > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> > index 37fb033e1c29..8dfdf2ff56a5 100644
> > --- a/drivers/net/phy/at803x.c
> > +++ b/drivers/net/phy/at803x.c
> > @@ -176,6 +176,7 @@
> >   #define AT8030_PHY_ID_MASK			0xffffffef
> >   
> >   #define QCA8081_PHY_ID				0x004dd101
> > +#define QCA8084_PHY_ID				0x004dd180
> >   
> >   #define QCA8327_A_PHY_ID			0x004dd033
> >   #define QCA8327_B_PHY_ID			0x004dd034
> > @@ -1760,6 +1761,9 @@ static bool qca808x_is_prefer_master(struct phy_device *phydev)
> >   
> >   static bool qca808x_has_fast_retrain_or_slave_seed(struct phy_device *phydev)
> >   {
> > +	if (phydev_id_compare(phydev, QCA8084_PHY_ID))
> > +		return false;
> > +
> >   	return linkmode_test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phydev->supported);
> >   }
>
>
> It looks like these patches need rebasing on net-next/main. It appears
> you are missing Christians patches.
>
>
>      Andrew
>
> ---
> pw-bot: cr

Oh, Yes, i will update the patch set based on the latest code, thanks.