[PATCH 3/4] mtd: spi-nor: sysfs: hide the flash name if not set

From: Tudor Ambarus
Date: Fri Dec 15 2023 - 03:22:39 EST


From: JaimeLiao <jaimeliao@xxxxxxxxxxx>

The flash name is not reliable as we saw flash ID collisions.
Hide the flash name if not set.

Signed-off-by: JaimeLiao <jaimeliao@xxxxxxxxxxx>
[ta: update commit subject and description]
Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
---
Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor | 3 +++
drivers/mtd/spi-nor/sysfs.c | 2 ++
2 files changed, 5 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor b/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor
index c800621eff95..6d7be97bf7d1 100644
--- a/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor
+++ b/Documentation/ABI/testing/sysfs-bus-spi-devices-spi-nor
@@ -25,6 +25,9 @@ KernelVersion: 5.14
Contact: linux-mtd@xxxxxxxxxxxxxxxxxxx
Description: (RO) Part name of the SPI NOR flash.

+ The attribute is not present if the jedec_id founded in
+ ID table but flash name didn't include in it.
+

What: /sys/bus/spi/devices/.../spi-nor/sfdp
Date: April 2021
diff --git a/drivers/mtd/spi-nor/sysfs.c b/drivers/mtd/spi-nor/sysfs.c
index 2dfdc555a69f..96064e4babf0 100644
--- a/drivers/mtd/spi-nor/sysfs.c
+++ b/drivers/mtd/spi-nor/sysfs.c
@@ -78,6 +78,8 @@ static umode_t spi_nor_sysfs_is_visible(struct kobject *kobj,

if (attr == &dev_attr_manufacturer.attr && !nor->manufacturer)
return 0;
+ if (attr == &dev_attr_partname.attr && !nor->info->name)
+ return 0;
if (attr == &dev_attr_jedec_id.attr && !nor->info->id && !nor->id)
return 0;

--
2.34.1