Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules

From: Maxime Chevallier
Date: Fri Dec 15 2023 - 10:39:29 EST


Hi all,

On Fri, 15 Dec 2023 10:59:28 +0100
Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx> wrote:

> Hi Andrew,
>
> On Fri, 15 Dec 2023 10:46:18 +0100
> Andrew Lunn <andrew@xxxxxxx> wrote:
> > So, if i'm reading this patch correctly, it only affects PHYs within
> > SFPs.
> >
> > The discussion went off on a tangent and also talked about media
> > converter PHYs, but from my reading of this patch, they are unaffected
> > by this patch. Do they however also suffer from this deadlock? Anybody
> > tested that?
>

I gave it a try with lockdep on a macchiatobin, but I couldn't even
reproduce the original issue (tested with the tip of net-next and net),
so I can't tell if the media-converter PHYs are affected as well. I got
no lockdep warnings regarding either paths.

Maxime