[PATCH RFC v15 23/30] virt: gunyah: Allow userspace to initialize context of primary vCPU

From: Elliot Berman
Date: Fri Dec 15 2023 - 19:26:09 EST


RM provides APIs to fill boot context the initial registers upon
starting the vCPU.

Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx>
---
drivers/virt/gunyah/vm_mgr.c | 75 ++++++++++++++++++++++++++++++++++++++++++++
drivers/virt/gunyah/vm_mgr.h | 1 +
include/uapi/linux/gunyah.h | 23 ++++++++++++++
3 files changed, 99 insertions(+)

diff --git a/drivers/virt/gunyah/vm_mgr.c b/drivers/virt/gunyah/vm_mgr.c
index 5666070453aa..a31a9f0a642c 100644
--- a/drivers/virt/gunyah/vm_mgr.c
+++ b/drivers/virt/gunyah/vm_mgr.c
@@ -542,6 +542,66 @@ static __must_check struct gunyah_vm *gunyah_vm_alloc(struct gunyah_rm *rm)
return ghvm;
}

+static long gunyah_vm_set_boot_context(struct gunyah_vm *ghvm,
+ struct gunyah_vm_boot_context *boot_ctx)
+{
+ u8 reg_set, reg_index; /* to check values are reasonable */
+ int ret;
+
+ reg_set = (boot_ctx->reg >> GUNYAH_VM_BOOT_CONTEXT_REG_SHIFT) & 0xff;
+ reg_index = boot_ctx->reg & 0xff;
+
+ switch (reg_set) {
+ case REG_SET_X:
+ if (reg_index > 31)
+ return -EINVAL;
+ break;
+ case REG_SET_PC:
+ if (reg_index)
+ return -EINVAL;
+ break;
+ case REG_SET_SP:
+ if (reg_index > 2)
+ return -EINVAL;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ ret = down_read_interruptible(&ghvm->status_lock);
+ if (ret)
+ return ret;
+
+ if (ghvm->vm_status != GUNYAH_RM_VM_STATUS_NO_STATE) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ ret = xa_err(xa_store(&ghvm->boot_context, boot_ctx->reg,
+ (void *)boot_ctx->value, GFP_KERNEL));
+out:
+ up_read(&ghvm->status_lock);
+ return ret;
+}
+
+static inline int gunyah_vm_fill_boot_context(struct gunyah_vm *ghvm)
+{
+ unsigned long reg_set, reg_index, id;
+ void *entry;
+ int ret;
+
+ xa_for_each(&ghvm->boot_context, id, entry) {
+ reg_set = (id >> GUNYAH_VM_BOOT_CONTEXT_REG_SHIFT) & 0xff;
+ reg_index = id & 0xff;
+ ret = gunyah_rm_vm_set_boot_context(
+ ghvm->rm, ghvm->vmid, reg_set, reg_index, (u64)entry);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
static int gunyah_vm_start(struct gunyah_vm *ghvm)
{
struct gunyah_rm_hyp_resources *resources;
@@ -582,6 +642,13 @@ static int gunyah_vm_start(struct gunyah_vm *ghvm)
}
ghvm->vm_status = GUNYAH_RM_VM_STATUS_READY;

+ ret = gunyah_vm_fill_boot_context(ghvm);
+ if (ret) {
+ dev_warn(ghvm->parent, "Failed to setup boot context: %d\n",
+ ret);
+ goto err;
+ }
+
ret = gunyah_rm_get_hyp_resources(ghvm->rm, ghvm->vmid, &resources);
if (ret) {
dev_warn(ghvm->parent,
@@ -683,6 +750,14 @@ static long gunyah_vm_ioctl(struct file *filp, unsigned int cmd,

return gunyah_gmem_modify_binding(ghvm, &args);
}
+ case GUNYAH_VM_SET_BOOT_CONTEXT: {
+ struct gunyah_vm_boot_context boot_ctx;
+
+ if (copy_from_user(&boot_ctx, argp, sizeof(boot_ctx)))
+ return -EFAULT;
+
+ return gunyah_vm_set_boot_context(ghvm, &boot_ctx);
+ }
default:
r = -ENOTTY;
break;
diff --git a/drivers/virt/gunyah/vm_mgr.h b/drivers/virt/gunyah/vm_mgr.h
index 1cad729b017a..a7fc7c376d1e 100644
--- a/drivers/virt/gunyah/vm_mgr.h
+++ b/drivers/virt/gunyah/vm_mgr.h
@@ -60,6 +60,7 @@ struct gunyah_vm {
struct list_head resource_tickets;
struct rb_root mmio_handler_root;
struct rw_semaphore mmio_handler_lock;
+ struct xarray boot_context;
};

int gunyah_vm_mmio_write(struct gunyah_vm *ghvm, u64 addr, u32 len, u64 data);
diff --git a/include/uapi/linux/gunyah.h b/include/uapi/linux/gunyah.h
index 1af4c5ae6bc3..a171185191ae 100644
--- a/include/uapi/linux/gunyah.h
+++ b/include/uapi/linux/gunyah.h
@@ -128,6 +128,29 @@ struct gunyah_map_mem_args {

#define GUNYAH_VM_MAP_MEM _IOW(GUNYAH_IOCTL_TYPE, 0x9, struct gunyah_map_mem_args)

+enum gunyah_vm_boot_context_reg {
+ REG_SET_X = 0,
+ REG_SET_PC = 1,
+ REG_SET_SP = 2,
+};
+
+#define GUNYAH_VM_BOOT_CONTEXT_REG_SHIFT 8
+#define GUNYAH_VM_BOOT_CONTEXT_REG(reg, idx) (((reg & 0xff) << GUNYAH_VM_BOOT_CONTEXT_REG_SHIFT) |\
+ (idx & 0xff))
+
+/**
+ * struct gunyah_vm_boot_context - Set an initial register for the VM
+ * @reg: Register to set. See GUNYAH_VM_BOOT_CONTEXT_REG_* macros
+ * @reserved: reserved for alignment
+ * @value: value to fill in the register
+ */
+struct gunyah_vm_boot_context {
+ __u32 reg;
+ __u32 reserved;
+ __u64 value;
+};
+#define GUNYAH_VM_SET_BOOT_CONTEXT _IOW(GUNYAH_IOCTL_TYPE, 0xa, struct gunyah_vm_boot_context)
+
/*
* ioctls for vCPU fds
*/

--
2.43.0