Re: [PATCH v2 2/3] rtc: sophgo: add rtc support for Sophgo CV1800 SoC

From: kernel test robot
Date: Sun Dec 17 2023 - 17:48:11 EST


Hi Jingbao,

kernel test robot noticed the following build errors:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on robh/for-next linus/master v6.7-rc5 next-20231215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Jingbao-Qiu/dt-bindings-rtc-sophgo-add-RTC-support-for-Sophgo-CV1800-series-SoC/20231217-191123
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20231217110952.78784-3-qiujingbao.dlmu%40gmail.com
patch subject: [PATCH v2 2/3] rtc: sophgo: add rtc support for Sophgo CV1800 SoC
config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20231218/202312180655.uM6zOZlv-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231218/202312180655.uM6zOZlv-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312180655.uM6zOZlv-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/rtc/rtc-cv1800.c: In function 'cv1800_rtc_alarm_irq_enable':
>> drivers/rtc/rtc-cv1800.c:89:17: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
89 | writel(REG_ENABLE_FUN, info->base_data + ALARM_ENABLE);
| ^~~~~~
drivers/rtc/rtc-cv1800.c: In function 'cv1800_rtc_set_alarm':
>> drivers/rtc/rtc-cv1800.c:113:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
113 | readl(info->base_data + SEC_CNTR_VAL);
| ^~~~~
cc1: some warnings being treated as errors


vim +/writel +89 drivers/rtc/rtc-cv1800.c

83
84 static int cv1800_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
85 {
86 struct cv1800_priv *info = dev_get_drvdata(dev);
87
88 if (enabled)
> 89 writel(REG_ENABLE_FUN, info->base_data + ALARM_ENABLE);
90 else
91 writel(REG_DISABLE_FUN, info->base_data + ALARM_ENABLE);
92
93 return 0;
94 }
95
96 static int cv1800_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
97 {
98 struct cv1800_priv *info = dev_get_drvdata(dev);
99 unsigned long alarm_time;
100
101 alarm_time = rtc_tm_to_time64(&alrm->time);
102
103 if (alarm_time > SEC_MAX_VAL)
104 return -EINVAL;
105
106 writel(REG_DISABLE_FUN, info->base_data + ALARM_ENABLE);
107
108 udelay(DEALY_TIME_PREPARE);
109
110 writel(alarm_time, info->base_data + ALARM_TIME);
111 writel(REG_ENABLE_FUN, info->base_data + ALARM_ENABLE);
112
> 113 readl(info->base_data + SEC_CNTR_VAL);
114
115 return 0;
116 }
117

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki