Re: [PATCH] arm64: defconfig: enable GPU clock controller for SM8[45]50

[Neil Armstrong]

On 16/12/2023 06:11, Bjorn Andersson wrote:
> On Mon, Dec 04, 2023 at 02:01:47PM +0100, Neil Armstrong wrote:
> > Enable GPU Clock Controller for SM8450 and SM8550 to allow using
> > Adreno GPU on these SoCs.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   arch/arm64/configs/defconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 5ad2b841aafc..56aebbdcdd40 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1266,6 +1266,8 @@ CONFIG_SM_TCSRCC_8550=y
> >   CONFIG_SM_GPUCC_6115=m
> >   CONFIG_SM_GPUCC_8150=y
> >   CONFIG_SM_GPUCC_8250=y
> > +CONFIG_SM_GPUCC_8450=y
> > +CONFIG_SM_GPUCC_8550=y
>
> I don't think these needs to be builtin, and if they do I'd like to see
> the reason captured in the commit message.

I don't have any good reasons... I'll resend with modules
since in my tests it worked fine as modules.

Neil

> Regards,
> Bjorn
>
> >   CONFIG_SM_VIDEOCC_8250=y
> >   CONFIG_QCOM_HFPLL=y
> >   CONFIG_CLK_GFM_LPASS_SM8250=m
> >
> > ---
> > base-commit: 9046d05c6ad632a271fc4173624e26f396975a80
> > change-id: 20231204-topic-sm8x50-upstream-gpucc-defconfig-3e3dc264be08
> >
> > Best regards,
> > --
> > Neil Armstrong <neil.armstrong@xxxxxxxxxx>