Re: [net PATCH] i40e: fix use-after-free in i40e_aqc_add_filters()

[xiaoke@xxxxxxxxxxxxxx]

On 2023/12/16 1:16, Brett Creeley wrote:
> On 12/13/2023 2:49 AM, Ke Xiao wrote:
> > Caution: This message originated from an External Source. Use proper 
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c 
> > b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > index 1ab8dbe2d880..16b574d69843 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > @@ -108,11 +108,17 @@ static void netdev_hw_addr_refcnt(struct 
> > i40e_mac_filter *f,
> >                                    struct net_device *netdev, int delta)
> >   {
> >          struct netdev_hw_addr *ha;
> > +       struct netdev_hw_addr_list *ha_list;
>
> Nit, needs to be in Reverse Christmas Tree (RCT) order.

Thanks, I will send the V2 to follow the rule.