Re: [PATCH] kbuild: rust: add `rustupoverride` target

From: Masahiro Yamada
Date: Mon Dec 18 2023 - 08:42:47 EST


On Mon, Dec 18, 2023 at 10:33 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Mon, Dec 18, 2023 at 1:10 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > In principle, Kbuild does not require internet connection,
> > or proactively change the system setting.
>
> Yeah, that was what I thought. I agree it can be surprising to have
> Make targets that modify environment/system-level bits (i.e. affecting
> things outside the build).
>
> > Rather, I will manually do this one time for the parent directory:
>
> That can work for many people, yeah. Though I imagine some people may
> want to keep builds (and sources) of different kernel versions in the
> same parent folder (or even other projects). But one can use nested
> overrides too.
>
> > If you want to provide a way for automated settings,
> > you can do it in a script you maintain.
>
> Sounds good. In that case, we can send to the list your patch from the
> `rust` branch if that is OK with you (i.e. I understand you would
> prefer to avoid not just `rustsetup` but also `rustupoverride`).
>
> Thanks Masahiro!
>
> Cheers,
> Miguel


Viresh's v2 was written without relying on this patch.

If that one is better described, that is OK too.





--
Best Regards
Masahiro Yamada