Re: [PATCH 4.19 00/36] 4.19.303-rc1 review

[Daniel Díaz]

Hello!

On 18/12/23 7:51 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.303 release.
> There are 36 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 20 Dec 2023 13:50:31 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.303-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

We see new warnings introduced in 32-bits system, with GCC 8, GCC 9, GCC 11, GCC 12, and Clang 17, on:
* arm
* i386
* arc
* mips
* powerpc
* s390
* sh
* sparc

It goes like this:

-----8<-----
  In file included from /builds/linux/include/linux/list.h:9,
                   from /builds/linux/include/linux/module.h:9,
                   from /builds/linux/net/core/skbuff.c:41:
  /builds/linux/net/core/skbuff.c: In function 'skb_segment':
  /builds/linux/include/linux/kernel.h:847:43: warning: comparison of distinct pointer types lacks a cast
    847 |                 (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
        |                                           ^~
  /builds/linux/include/linux/kernel.h:861:18: note: in expansion of macro '__typecheck'
    861 |                 (__typecheck(x, y) && __no_side_effects(x, y))
        |                  ^~~~~~~~~~~
  /builds/linux/include/linux/kernel.h:871:31: note: in expansion of macro '__safe_cmp'
    871 |         __builtin_choose_expr(__safe_cmp(x, y), \
        |                               ^~~~~~~~~~
  /builds/linux/include/linux/kernel.h:880:25: note: in expansion of macro '__careful_cmp'
    880 | #define min(x, y)       __careful_cmp(x, y, <)
        |                         ^~~~~~~~~~~~~
  /builds/linux/net/core/skbuff.c:3630:32: note: in expansion of macro 'min'
   3630 |                 partial_segs = min(len, GSO_BY_FRAGS - 1) / mss;
        |                                ^~~
----->8-----

Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx