Re: [PATCH 3/4] arm64: dts: ti: iot2050: Factor out arduino connector bits

From: Jan Kiszka
Date: Tue Dec 19 2023 - 03:07:07 EST


On 19.12.23 08:51, Krzysztof Kozlowski wrote:
> On 18/12/2023 17:35, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>>
>> A new variant is to be added which will not have a arduino connector
>> like the existing ones. Factor out all bits that are specific to this
>> connector.
>>
>> The split is not perfect because wkup_gpio0 is defined based on what is
>> common to all variants having the connector, thus containing also
>> connector-unrelated information. But this is still cleaner than
>> replicating this node into all 4 variants.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>> ---
>> .../ti/k3-am65-iot2050-arduino-connector.dtsi | 768 ++++++++++++++++++
>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 753 -----------------
>
> Please use proper -B/-M/-C arguments so code movements will be detected.
>

Those are in place but have no impact, likely because the source file is
still ~700 lines after the shuffling.

Jan

--
Siemens AG, Technology
Linux Expert Center