Re: [PATCH v3 1/2] dt-bindings: iio: dac: add MCP4821

[Krzysztof Kozlowski]

On 19/12/2023 09:42, Anshul Dalal wrote:
> On 12/19/23 13:29, Krzysztof Kozlowski wrote:
>> On 18/12/2023 17:47, Anshul Dalal wrote:
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  vdd-supply: true
>>> +
>>> +  ldac-gpios:
>>> +    description: |
>>> +      Active Low LDAC (Latch DAC Input) pin used to update the DAC output.
>>> +    maxItems: 1
>>> +
>>> +  shdn-gpios:
>>
>> Open gpio-consumer-common.yaml and look at entries there.
>>
> 
> Should I name the property `powerdown-gpios` instead of `shdn-gpios` as
> specified in gpio-consumer-common.yaml?

Yes. You can provide the name of actual pin in description.

> Furthermore, do I need to add gpio-consumer-common.yaml as a ref?

No.


Best regards,
Krzysztof