On 19/12/2023 10:36, Aiqun Yu (Maria) wrote:I don't find any reason why "qcom,mdss-dsi-ctrl" driver node need to have address/size-cells properties. Document Bindings should also be fixed.
On 12/19/2023 3:17 PM, Krzysztof Kozlowski wrote:
On 19/12/2023 01:31, Tengfei Fan wrote:Comments can be more readable:
The address/size-cells in mdss_dsi1 node have not ranges and child also
have not reg, then this leads to dtc W=1 warnings:
"mdss_dsi1" node don't have "ranges" or child "reg" property, while it
have address/size-cells properties. This caused
"avoid_unnecessary_addr_size" warning from dtb check.
Remove address/size-cells properties for "mdss_dsi1" node.
I cannot parse it. Address/size cells never have ranges or children.Pls help to comment on the revised commit message. Every time I write a
They cannot have. These are uint32 properties.
commit message, also takes a while for me to double confirm whether
others can understand me correctly as well. Feel free to let us know if
it is not readable to you. It will help us as non-English native developers.
Per my understanding, "qcom,mdss-dsi-ctrl" driver node like "mdss_dsi1"
sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
---
I disagreed with the patch before. You resubmit it without really
addressing my concerns.
I am not sure if this is correct fix and I want to fix all of such
errors (there are multiple of them) in the same way. Feel free to
propose common solution based on arguments.
don't need to have address/size-cells properties.
Just because dtc says so? And what about bindings?
Our plan is to fix the bindings as well.
Feel free to let us know whether there is different idea of
"address/size-cells" needed for the "qcom,mdss-dsi-ctrl" driver node.
The bindings expressed that idea. If the binding is incorrect, fix the
binding and the DTS. If the binding is correct, provide rationale why it
somehow does not apply here etc.
Best regards,
Krzysztof