Re: [PATCH v3 7/8] dt-bindings: arm: Add support for TPDM CMB MSR register

From: Jinlong Mao
Date: Tue Dec 19 2023 - 05:27:44 EST




On 12/18/2023 8:17 PM, Jinlong Mao wrote:


On 12/18/2023 7:56 PM, Suzuki K Poulose wrote:
Hi Tingwei Zhang

On 18/12/2023 11:23, Tingwei Zhang wrote:
On 12/18/2023 6:47 PM, Suzuki K Poulose wrote:
Tao Zhang,

On 21/11/2023 07:24, Krzysztof Kozlowski wrote:
On 21/11/2023 03:24, Tao Zhang wrote:
Add property "qcom,cmb_msr_num" to support CMB MSR(mux select register)
for TPDM. It specifies the number of CMB MSR registers supported by
the TDPM.

Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
---

I prefer not to take any new Qualcomm Coresight bindings or Qualcomm SoC
DTS nodes with Coresight till we fix all existing warnings. I don't know
how to fix them, so I need help with them. No such fixing happened so
far from Qcom, so pushback is my only way to get any attention.

I already commented on this in other email thread.

Are you addressing this ?
The DT warning is fixed in https://lore.kernel.org/linux-arm-msm/20231210072633.4243-1-quic_jinlmao@xxxxxxxxxxx/.
It's applied to linux-arm-msm yesterday.

How are you supporting remote-etm ? We haven't merged the support for it in drivers ? We haven't even reviewed the remote-etm support patches ? Why weren't the coresight maintainers Cc ed on the "new" binding support ?

Suzuki


Hi Suzuki,

Sorry for missing coresight maintainers in the remote-etm binding patch.
From the comments, we can add binding for the connected hardware first.

https://lkml.org/lkml/2023/11/30/539

Thanks
Jinlong Mao

Hi Suzuki,

The dt-binding patch of remote-etm is not applied. I run dtbs_check without dt-binding patch, there is no device tree warning. I will
merge the dt-binding patch of remote-etm to the remote etm patches to
make them review together.

[2/4] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property
commit: 9a6fc510a6a3ec150cb7450aec1e5f257e6fc77b
[3/4] arm64: dts: qcom: msm8998: Fix 'out-ports' is a required property
commit: ae5ee3562a2519214b12228545e88a203dd68bbd
[4/4] arm64: dts: qcom: Fix coresight warnings in in-ports and out-ports
commit: bdb6339fd46b8702ea7411b0b414587b86a40562

Thanks
Jinlong Mao


Suzuki


Best regards,
Krzysztof