Re: [PATCH] thermal: core: Print out thermal zone name on update_temperature error

[Konrad Dybcio]

On 18.12.2023 20:40, Rafael J. Wysocki wrote:
> On Mon, Dec 18, 2023 at 3:40 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>
>> Currently, we can encounter an error like this:
>>
>>   thermal thermal_zone48: failed to read out thermal zone (-19)
>>
>> It's good to know that there's been an issue, but on some occasions
>> (like the error happening in the middle of a platform crash), one may
>> not be able to look up what kind of thermal zone that is.
>>
>> Add the TZ name to the error message in order to speed up debugging.
> 
> s/name/type/ ?  It looks like that's what you mean.
> 
> First, the tz type is not its name (because there may be multiple
> zones of the same type) and it would be consistent with the first
> paragraph above.
That's possible, I'm no expert wrt thermal :)

Would you be okay with this change, together with an amended commit
message?

Konrad