Re: [PATCH v4 2/9] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible

From: Krzysztof Kozlowski
Date: Tue Dec 19 2023 - 08:19:34 EST


On 19/12/2023 13:49, Cristian Ciocaltea wrote:
>>> reg:
>>> maxItems: 1
>>> @@ -46,23 +50,6 @@ properties:
>>> - const: tx
>>> - const: gtx
>>>
>>> - interrupts:
>>> - minItems: 3
>>> - maxItems: 3
>>> -
>>> - interrupt-names:
>>> - minItems: 3
>>> - maxItems: 3
>>> -
>>> - resets:
>>> - minItems: 2
>>> - maxItems: 2
>>
>> What is the point of your previous patch if you immediately remove it?
>> It is a no-op. Just mention in this commit msg, that both resets and
>> reset-names are coming from snps,dwmac so they can be removed from
>> top-level entirely.
>
> This has been discussed during v2 review [1], where I also provided the
> rational behind not updating reset-names. So the code was not deleted,
> but moved under an if clause.
>
> Thanks for reviewing,
> Cristian
>
> [1]: https://lore.kernel.org/lkml/f4d0b216-5bdc-4559-aabb-8af638d33721@xxxxxxxxxxxxx/

I don't see it being addressed:

https://lore.kernel.org/lkml/35556392-3b9a-4997-b482-082dc2f9121f@xxxxxxxxxx/

Repeating the same and the same :/

Best regards,
Krzysztof