Re: [PATCH] ASoC: xilinx: Embed IEC958 sample rate val to channel status register

From: Mark Brown
Date: Tue Dec 19 2023 - 09:02:18 EST


On Tue, Dec 19, 2023 at 05:59:55PM +0530, Sunil Vaghela wrote:
> As per IEC 60958 specification, bits 24 to 27 of channel status register
> indicates audio sample frequency. If these bits are not set, audio
> analyzer always shows 44.1KHz sample rate, irrespective of any sample
> rate audio is being played.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c: In function ‘xlnx_form
atter_pcm_hw_params’:
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:572:26: error: ‘struct
xlnx_pcm_drv_data’ has no member named ‘nodes’
572 | if ((strstr(adata->nodes[XLNX_PLAYBACK]->name, "hdmi")) ||
| ^~
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:572:34: error: ‘XLNX_PL
AYBACK’ undeclared (first use in this function)
572 | if ((strstr(adata->nodes[XLNX_PLAYBACK]->name, "hdmi")) ||
| ^~~~~~~~~~~~~
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:572:34: note: each unde
clared identifier is reported only once for each function it appears in
/build/stage/linux/sound/soc/xilinx/xlnx_formatter_pcm.c:573:26: error: ‘struct xlnx_pcm_drv_data’ has no member named ‘nodes’
573 | (strstr(adata->nodes[XLNX_PLAYBACK]->name, "dp"))) {
| ^~

Attachment: signature.asc
Description: PGP signature