Re: [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it

From: Andy Shevchenko
Date: Tue Dec 19 2023 - 09:44:44 EST


On Tue, Dec 19, 2023 at 05:31:38PM +0300, Serge Semin wrote:
> On Tue, Dec 19, 2023 at 04:17:16PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 19, 2023 at 11:14 AM Serge Semin <fancer.lancer@xxxxxxxxx> wrote:
> > > On Tue, Dec 19, 2023 at 09:37:51AM +0800, xiongxin wrote:
> >
> > ...
> >
> > > Also note all the tags you've already got must be preserved on the
> > > next patch revisions. One more time:
> >
> > > Acked-by: Serge Semin <fancer.lancer@xxxxxxxxx>
> >
> > I recommend using `b4` for that.
> >
> > it harvests tags from the email thread, so no need to care about
> > possible misses.
>
> AFAICS it doesn't pick up the tags from the previous revisions at
> least if the new patch wasn't submitted as in-reply-to the prev one.

???

> Just tested it on v3. b4 found my new ab-tag only and no yours rb-tag.
> Did you mean something other than I thought you did?

Grabbing thread from lore.kernel.org/all/mdogxxro42ymeaykrgqpld2kqbppopbywcm76osskuf3df72sl@5jalt26vzcv4/t.mbox.gz
Analyzing 4 messages in the thread
Checking attestation on all messages, may take a moment...
---
[PATCH v2] gpio: dwapb: mask/unmask IRQ when disable/enale it
+ Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
+ Acked-by: Serge Semin <fancer.lancer@xxxxxxxxx> (✓ DKIM/gmail.com)

The flow you need to follow is that

git checkout $BASE # gpio/for-next in this case
b4 am ... # as above
git am ...
...address comments...
git commit -a -s --amend
git format-patch ... -1 HEAD~0
git send-email ...

--
With Best Regards,
Andy Shevchenko