Re: [PATCH 2/2] iio: pressure: change driver for Honeywell MPR series

From: Andy Shevchenko
Date: Tue Dec 19 2023 - 10:42:02 EST


On Tue, Dec 19, 2023 at 03:02:21PM +0200, Petre Rodan wrote:
> ChangeLog
> - rewrite flow so that driver can use either i2c or spi as communication bus
> - add spi driver (tested on MPRLS0015PA0000SA)
> - add pressure-triplet property that automatically sets pmin, pmax
> - fix transfer-function enum typo based on previous review [1]
> - fix interrupt example in binding file (FALLING -> RISING edge)
> - indentation changes based on previous code reviews
> - renamed mpr_read_pressure to mpr_read_conversion since the sensor is
> supposed to also provide temperature measuremets
> (but I think mine is broken since the raw temperature value is always
> 0x800000 - so temp reading not currently implemented)

Changelog...

> I've been told in the past that the use of mutexes is redundant in these cases
> so please assess if the guard() from the driver code is required or should be
> removed.

A comment...

> patch uses device_property_match_property_string() from the 'togreg' branch

Another comment...

> [1]: https://lore.kernel.org/lkml/20231116-grudge-hankering-b7a71d831b93@squawk/T/

Some Link: (should it be a tag?)...

Where is the commit message? Or is this just an intermediate change
to show what will be in the next version? I'm confused.

--
With Best Regards,
Andy Shevchenko