Re: [PATCH v3] gpio: dwapb: mask/unmask IRQ when disable/enale it

From: Serge Semin
Date: Tue Dec 19 2023 - 17:16:29 EST


On Tue, Dec 19, 2023 at 05:10:02PM -0500, Konstantin Ryabitsev wrote:
> On Wed, Dec 20, 2023 at 12:58:16AM +0300, Serge Semin wrote:
> > > It's a known limitation at this time, but it will be improved in the near
> > > future and we'll be able to grab trailers across revisions as long as the
> > > patch-id remains the same.
> >
> > Ok. Thanks for the note.
> >
> > I am sure you are well aware of that, but in some cases the tags are
> > intentionally omitted in the new patch revisions for instance due to
> > significant patch body change. How are you going to handle that?
>

> The patch-id (generated with `git patch-id --stable`), would change if the
> patch body is changed (except things like whitespace). This is exactly the
> behaviour that we need -- if a tag was sent to a different version of the
> patch, then we no longer want to retrieve it.
>
> > Just make the tags picking up optional? Perhaps making the tags handling
> > interactive with printing a text/context around the tag?
>
> We may indeed be able to do --interactive for some of the commands in the
> future, but the goal is to automate things away.

Got it. Thanks. Can't wait to see that in action.

-Serge(y)

>
> -K