Re: [PATCH] scripts: kernel-doc: Bug fixed for erroneous warning

From: Randy Dunlap
Date: Wed Dec 20 2023 - 01:50:07 EST




On 12/19/23 22:35, Muhammad Muzammil wrote:
> HI,
>
> 1) I already have the below patch but it does not work.
> https://lore.kernel.org/linux-doc/20231215001347.work.151-kees@xxxxxxxxxx/
>
> 2) When I applied the below patch. It works.
> https://lore.kernel.org/linux-doc/87le9rjb4y.fsf@xxxxxxxxxxxx/

Thanks!


> On Wed, Dec 20, 2023 at 11:29 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>
>> Hi,
>>
>> On 12/19/23 22:24, Muhammad Muzammil wrote:
>>> From: Muzammil Ashraf <m.muzzammilashraf@xxxxxxxxx>
>>>
>>> kernel-doc: fixed erroneous warning generated by '__counted_by'
>>>
>>> Signed-off-by: Muzammil Ashraf <m.muzzammilashraf@xxxxxxxxx>
>>> ---
>>> scripts/kernel-doc | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
>>> index 1484127db104..ea9688df0e93 100755
>>> --- a/scripts/kernel-doc
>>> +++ b/scripts/kernel-doc
>>> @@ -1661,6 +1661,7 @@ sub check_sections($$$$$) {
>>> }
>>> elsif (($decl_type eq "struct") or
>>> ($decl_type eq "union")) {
>>> + next if (index("@_", "__counted_by") != -1);
>>> emit_warning("${file}:$.",
>>> "Excess $decl_type member " .
>>> "'$sects[$sx]' " .
>>
>> One of both of these patches should be enough. Can you test these
>> instead of your patch, please?
>>
>> https://lore.kernel.org/linux-doc/20231215001347.work.151-kees@xxxxxxxxxx/
>>
>> https://lore.kernel.org/linux-doc/87le9rjb4y.fsf@xxxxxxxxxxxx/
>>
>> Thanks.
>>
>> --
>> #Randy
>> https://people.kernel.org/tglx/notes-about-netiquette
>> https://subspace.kernel.org/etiquette.html

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html