Re: [PATCH V2 4/5] nvmem: u-boot-env: improve coding style

[Miquel Raynal]

Hi Rafał,

zajec5@xxxxxxxxx wrote on Tue, 19 Dec 2023 18:40:24 +0100:

> From: Rafał Miłecki <rafal@xxxxxxxxxx>
> 
> 1. Prefer kzalloc() over kcalloc()
>    See memory-allocation.rst which says: "to be on the safe side it's
>    best to use routines that set memory to zero, like kzalloc()"
> 2. Drop dev_err() for u_boot_env_add_cells() fail
>    It can fail only on -ENOMEM. We don't want to print error then.
> 3. Add extra "crc32_addr" variable
>    It makes code reading header's crc32 easier to understand / review.
> 
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

Looks much nicer :)

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Thanks,
Miquèl