Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

From: Julia Lawall
Date: Wed Dec 20 2023 - 02:40:32 EST




On Tue, 19 Dec 2023, Luis Chamberlain wrote:

> On Tue, Dec 19, 2023 at 10:21:25PM +0100, Julia Lawall wrote:
> > > As I noted, I think this is a generically neat endeavor and so I think
> > > it would be nice to shorthand *any* member of the struct. ctl->any.
> > > Julia, is that possible?
> >
> > What do you mean by *any* member?
>
> I meant when any code tries to assign a new variable to any of the
> members of the struct ctl_table *foo, so any foo->*any*

Declaring any to be an identifier metavariable would be sufficient.

>
> > If any is an identifier typed
> > metavariable then that would get any immediate member. But maybe you want
> > something like
> >
> > <+...ctl->any...+>
> >
> > that will match anything that has ctl->any as a subexpression?
>
> If as just an expression, then no, we really want this to be tied to
> the data struture in question we want to modify.

What about foo->a.b? Or maybe that doesn't occur in your structure?

julia