Re: [PATCH v4 4/4] KVM: s390: Minor refactor of base/ext facility lists

From: Janosch Frank
Date: Wed Dec 20 2023 - 05:49:36 EST


On 12/19/23 15:08, Nina Schoetterl-Glausch wrote:
Directly use the size of the arrays instead of going through the
indirection of kvm_s390_fac_size().
Don't use magic number for the number of entries in the non hypervisor
managed facility bit mask list.
Make the constraint of that number on kvm_s390_fac_base obvious.
Get rid of implicit double anding of stfle_fac_list.

Reviewed-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
Signed-off-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>

@Nina: I'm currently still recovering from a cold and hence I'm not fully able to grasp this patch.

May I drop it and we re-visit it next year for 6.9?