Re: [PATCH v8] ARM: dts: aspeed: Adding Facebook Bletchley BMC

[Patrick Williams]

---
Patrick Williams

> On Dec 20, 2023, at 2:07 AM, Lukas Wunner <lukas@xxxxxxxxx> wrote:
> 
> On Tue, Dec 07, 2021 at 05:49:24PM +0800, Howard Chiu wrote:
>> Initial introduction of Facebook Bletchley equipped with
>> Aspeed 2600 BMC SoC.
> [...]
>> +        tpmdev@0 {
>> +            compatible = "tcg,tpm_tis-spi";
> 
> What's the chip used on this board?  Going forward, the DT schema for TPMs
> requires the exact chip name in addition to the generic "tcg,tpm_tis-spi".

Why is this a requirement?  This assumes there is exactly one chip. TPMs are often placed on a pluggable module in which multiple vendors could be used. There is no way in the DTS to specify multiple compatible chips. 

>> +            spi-max-frequency = <33000000>;
>> +            reg = <0>;
>> +        };
>> +    };