Re: [PATCH v2] gpio: sysfs: drop tabs from local variable declarations

From: Andy Shevchenko
Date: Wed Dec 20 2023 - 09:52:06 EST


On Wed, Dec 20, 2023 at 09:09:42AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Older code has an annoying habit of putting tabs between the type and the
> name of the variable. This doesn't really add to readability and newer
> code doesn't do it so make the entire file consistent.

So, I would go with reversed xmas tree ordering in the lines you changed.
It will decrease the churn for both: the future changes and backporting
efforts.

I explained that in my previous reply to v1 thread.

--
With Best Regards,
Andy Shevchenko