Re: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library

[Markus Elfring]

…
> +++ b/drivers/ras/amd/atl/access.c
> @@ -0,0 +1,106 @@
…
> +static int __df_indirect_read(u16 node, u8 func, u16 reg, u8 instance_id, u32 *lo)
…

I suggest to reconsider the usage of double underscores for identifiers.
How do you think about to avoid that this software depends on undefined behaviour?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus