Re: [PATCH 15/18] serial: sc16is7xx: pass R/W buffer in FIFO functions

From: Andy Shevchenko
Date: Wed Dec 20 2023 - 10:59:47 EST


On Tue, Dec 19, 2023 at 12:18:59PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> To simplify function by avoiding cast.
>
> This is similar to what is done in max310x driver.

...

> ---
> If deemed appropriate for stable kernel backporting:

I don't think it's eligible.

> ---

I don't see the necessity of the change, OTOH it's harmless.
The problem is that commit message is basically "Yeah, we
do cargo cult." Because I haven't seen what casting you are
talking about.

--
With Best Regards,
Andy Shevchenko