Re: [PATCH 08/18] serial: sc16is7xx: add driver name to struct uart_driver

From: Hugo Villeneuve
Date: Wed Dec 20 2023 - 11:16:27 EST


On Wed, 20 Dec 2023 17:48:03 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Tue, Dec 19, 2023 at 12:18:52PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> >
> > Make sure that the driver name is displayed instead of "unknown" when
> > displaying the driver infos:
> >
> > Before:
> > cat /proc/tty/drivers | grep ttySC
> > unknown /dev/ttySC 243 0-7 serial
> >
> > After:
> > cat /proc/tty/drivers | grep ttySC
> > sc16is7xx /dev/ttySC 243 0-7 serial
>
> "Useless use of cat" (you can google for this phrase, it's famous).
>
> grep ... /proc/...
>
> will work :-)
>
> Otherwise LGTM!

Old habits die hard :)

Interesting read!

Will modify commit message in V2.

Thank you.

Hugo Villeneuve