Re: [PATCH] net: sched: em_text: fix possible memory leak in em_text_destroy()

From: kernel test robot
Date: Wed Dec 20 2023 - 18:30:08 EST


Hi Hangyu,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]
[also build test ERROR on net/main linus/master v6.7-rc6 next-20231220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Hangyu-Hua/net-sched-em_text-fix-possible-memory-leak-in-em_text_destroy/20231220-111317
base: net-next/main
patch link: https://lore.kernel.org/r/20231220030838.11751-1-hbh25y%40gmail.com
patch subject: [PATCH] net: sched: em_text: fix possible memory leak in em_text_destroy()
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231221/202312210705.j1LTJmpH-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231221/202312210705.j1LTJmpH-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312210705.j1LTJmpH-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> net/sched/em_text.c:102:9: error: incompatible integer to pointer conversion passing 'unsigned long' to parameter of type 'const void *' [-Wint-conversion]
kfree(m->data);
^~~~~~~
include/linux/slab.h:227:24: note: passing argument to parameter 'objp' here
void kfree(const void *objp);
^
1 error generated.


vim +102 net/sched/em_text.c

97
98 static void em_text_destroy(struct tcf_ematch *m)
99 {
100 if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) {
101 textsearch_destroy(EM_TEXT_PRIV(m)->config);
> 102 kfree(m->data);
103 }
104 }
105

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki