Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru

[Bixuan Cui]

在 2023/12/21 1:54, Yu Zhao 写道:
> > Signed-off-by: Bixuan Cui<cuibixuan@xxxxxxxx>
> > Reviewed-by: Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > v4: Add Reviewed-by and Changlog to every patch.
> Where did Andrew provide his Reviewed-by?Hi,
I just want to add Reviewed-by to my patch to thank the reveiw of Steven 
and Andrew.:-)


> > v2: Modify trace_mm_vmscan_lru_shrink_inactive() in evict_folios() at the same time to fix build error.
> The reason v3 was NAK'ed was not mentioned or fixed in v4.
>
> So NAK again.
The build error pointed out by Andrew has been fixed in [mm: vmscan: add 
new event to trace shrink lru]:

@@ -4524,9 +4528,10 @@ static int evict_folios(struct lruvec *lruvec, 
struct scan_control *sc, int swap
 	if (list_empty(&list))
 		return scanned;
 retry:
+	trace_mm_vmscan_lru_shrink_inactive_start(pgdat->node_id);
 	reclaimed = shrink_folio_list(&list, pgdat, sc, &stat, false);
 	sc->nr_reclaimed += reclaimed;
-	trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id,
+	trace_mm_vmscan_lru_shrink_inactive_end(pgdat->node_id,
 			scanned, reclaimed, &stat, sc->priority,
 			type ? LRU_INACTIVE_FILE : LRU_INACTIVE_ANON);

Are there any other reasons for NAK? And thank you for your review.


Thanks
Bixuan Cui