RE: [EXT] Re: [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat

From: David Lin
Date: Thu Dec 21 2023 - 03:18:15 EST


> From: Brian Norris <briannorris@xxxxxxxxxxxx>
> Sent: Thursday, December 21, 2023 10:39 AM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>; stable@xxxxxxxxxxxxxxx; kernel test robot
> <lkp@xxxxxxxxx>; Dan Carpenter <error27@xxxxxxxxx>
> Subject: [EXT] Re: [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Thu, Dec 21, 2023 at 09:55:11AM +0800, David Lin wrote:
> > Variable firmware_stat is possible to be used without initialization.
> >
> > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx>
> > Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> > Closes:
> https://lore.kern/
> el.org%2Fr%2F202312192236.ZflaWYCw-lkp%40intel.com%2F&data=05%7C02
> %7Cyu-hao.lin%40nxp.com%7C813d1bc65e8b41e8349808dc01cdf23f%7C686e
> a1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638387231239605883%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mGQ3tVhTOnyO9wXiE
> qI%2Bsym7LqLP5B6bEMofhhsXBzg%3D&reserved=0
>
> Repeating:
>
> Acked-by: Brian Norris <briannorris@xxxxxxxxxxxx>

Sorry. I sent out v2 then I found you acked v1. That is the reason I won't add "Acked-by" to v2.