Re: [PATCH] thermal: cpuidle_cooling: fix kernel-doc warning and a spello

From: Rafael J. Wysocki
Date: Thu Dec 21 2023 - 06:07:11 EST


On Thu, Dec 21, 2023 at 6:51 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Correct one misuse of kernel-doc notation and one spelling error as
> reported by codespell.
>
> cpuidle_cooling.c:152: warning: cannot understand function prototype: 'struct thermal_cooling_device_ops cpuidle_cooling_ops = '
>
> For the kernel-doc warning, don't use "/**" for a comment on data.
> kernel-doc can be used for structure declarations but not definitions.
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Amit Daniel Kachhap <amit.kachhap@xxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: Lukasz Luba <lukasz.luba@xxxxxxx>
> Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> ---
> drivers/thermal/cpuidle_cooling.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
> --- a/drivers/thermal/cpuidle_cooling.c
> +++ b/drivers/thermal/cpuidle_cooling.c
> @@ -66,7 +66,7 @@ static unsigned int cpuidle_cooling_runt
> * @state : a pointer to the state variable to be filled
> *
> * The function always returns 100 as the injection ratio. It is
> - * percentile based for consistency accross different platforms.
> + * percentile based for consistency across different platforms.
> *
> * Return: The function can not fail, it is always zero
> */
> @@ -146,7 +146,7 @@ static int cpuidle_cooling_set_cur_state
> return 0;
> }
>
> -/**
> +/*
> * cpuidle_cooling_ops - thermal cooling device ops
> */
> static struct thermal_cooling_device_ops cpuidle_cooling_ops = {

Applied as 6.8 material, thanks!