Re: [PATCH 7/8] firewire: core: detect model name for legacy layout of configuration ROM

[Adam Goldman]

Hi,

> -	ret = fw_csr_string(dir, attr->key, buf, bufsize);
> +	for (i = 0; i < ARRAY_SIZE(directories) && !!directories[i]; ++i) {
> +		int result = fw_csr_string(directories[i], attr->key, buf, bufsize);
> +		// Detected.
> +		if (result >= 0)
> +			ret = result;
> +	}
>  
>  	if (ret >= 0) {

ret is an automatic variable with no initializer. Unless you initialize 
it (to -ENOENT), this is UB.

-- Adam