Re: [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes

[Konrad Dybcio]

On 21.12.2023 12:19, Manish Pandey wrote:
> Add UFS host controller and Phy nodes for
> Qualcomm qcm6490 Board.
> 
> Signed-off-by: Manish Pandey <quic_mapa@xxxxxxxxxxx>
> ---
> Changes from v1:
> - updated with correct patchset
Well no, this clearly hasn't been compile-tested..

Please also include the board name in the subject
(qcm6490: -> qcm6490-idp:)
> 
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 03e97e27d16d..51efd46b576c 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -440,6 +440,25 @@
>  	status = "okay";
>  };
>  
> +&ufs_mem_hc {
> +	reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> +	vcc-supply = <&vreg_l7b_2p9>;
> +	vcc-max-microamp = <800000>;
> +	vccq-supply = <&vreg_l9b_1p2>;
> +	vccq-max-microamp = <900000>;
> +	vccq2-supply = <&vreg_l9b_1p2>;
> +	vccq2-max-microamp = <900000>;
These regulators should get regulator-allow-set-load since the
UFS driver expects to perform current/mode setting ops on them

Konrad