Re: [RFC PATCH] sched: fair: reset task_group.load_avg when there are no running tasks.

From: Vincent Guittot
Date: Thu Dec 21 2023 - 10:28:35 EST


Hi Aaron,

On Thu, 21 Dec 2023 at 09:21, Aaron Lu <aaron.lu@xxxxxxxxx> wrote:
>
> Hi Vincent,
>
> Thanks for the heads up.
>
> On Wed, Dec 20, 2023 at 06:31:08PM +0100, Vincent Guittot wrote:
> > Aaron,
> > Could you run the tests that you run for testing "Ratelimit update to
> > tg->load_avg" and check if this patch impacts your performance ?
>
> I run hackbench/netperf/postgres_sysbench with nr_thread=nr_cpu on a 2
> sockets/120cores/240cpus Intel server and didn't notice any performance
> change after applying your diff so I think it's not a problem.

Thanks for the tests.

I'm going to prepare a proper patch

>
> Regards,
> Aaron