RE: [PATCH iwl-net v4] i40e: Restore VF MSI-X state during PCI reset

From: Keller, Jacob E
Date: Thu Dec 21 2023 - 17:34:08 EST




> -----Original Message-----
> From: Staikov, Andrii <andrii.staikov@xxxxxxxxx>
> Sent: Thursday, December 21, 2023 6:00 AM
> To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Ostrowska, Karen
> <karen.ostrowska@xxxxxxxxx>; Mateusz Palczewski
> <mateusz.palczewski@xxxxxxxxx>; Drewek, Wojciech
> <wojciech.drewek@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>
> Subject: RE: [PATCH iwl-net v4] i40e: Restore VF MSI-X state during PCI reset
>
>
> > The ice driver recently started caching the PCI device structure
> > pointers in their VF structure instead of having to do this sort of
> > lookup on the fly.
> >
> > See 31642d2854e2 ("ice: store VF's pci_dev ptr in ice_vf") [1][2]
> >
> > [1]:
> > https://lore.kernel.org/intel-wired-lan/20230912115626.105828-1-
> mateusz.polchlopek@xxxxxxxxx/
> > [2]:
> > https://lore.kernel.org/netdev/20231019173227.3175575-4-
> jacob.e.keller@xxxxxxxxx/
> >
> > Can we do something similar for i40e?
>
> For now we don't anticipate much benefit of this approach, and we want relatively
> smaller change for a bugfix.
>
> Regards,
> Staikov Andrii

Sure. If we ever need the VF PCI dev pointer in the future we can look into this. Not a huge deal for this since it’s the only place we use it currently anyways. Thanks for the response!

Thanks,
Jake