Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

From: Google
Date: Thu Dec 21 2023 - 20:48:57 EST


On Thu, 21 Dec 2023 20:28:13 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Fri, 22 Dec 2023 10:21:48 +0900
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:
>
> > The testcase itself is OK but is there any way to identify the system
> > supports eventfs or not? I ran this test on v6.5.13 for checking then
> > it failed. We may need to skip (unsupported) this test for such case.
>
> Hmm, honestly, it should technically work on all past versions.
>
> I'll try it out to see what fails for 6.5.13. Perhaps there was another bug
> that the stable releases need fixing for?

I found that the failure was my environmental issue.
BTW, for busybox environment,

+instance="foo-$(mktemp -u XXXXX)"

This doesn't work. it needs XXXXXX (6 times X). And this is
somewhat wrong usage of mktemp because it can not check there is
foo-<random>.
What about change it as

instance="$(mktemp -u foo-XXXXXX)"

?

Thanks,

>
> -- Steve


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>