Re: [PATCH v1 2/2] ASoC: starfive: Add drivers of Cadence Multi-Channel I2S Controller

From: Xingyu Wu
Date: Fri Dec 22 2023 - 04:20:03 EST


On 2023/12/21 20:55, Mark Brown wrote:
> On Thu, Dec 21, 2023 at 11:32:23AM +0800, Xingyu Wu wrote:
>
>> sound/soc/starfive/cdns-jh8100-i2s-pcm.c | 262 ++++++++
>> sound/soc/starfive/cdns-jh8100-i2s.c | 727 +++++++++++++++++++++++
>> sound/soc/starfive/cdns-jh8100-i2s.h | 171 ++++++
>
> If this is a Cadence IP why is the entire driver SoC specific?

This a new driver about this Cadence I2S controller. Should I create a new folder and file like this:

sound/soc/cdns/cdns-i2s*

and I use different compatible to support other SoC like JH8100?

Best regards,
Xingyu Wu