Re: [PATCH v1 1/2] dt-bindings: ASoC: Add Cadence I2S controller for StarFive JH8100 SoC

[Mark Brown]

On Fri, Dec 22, 2023 at 05:55:14PM +0800, Xingyu Wu wrote:

> The Cadence I2S can support 8 channels. But on the JH8100 SoC, two
> instances of this just provide 4 channels to use, one just provides 2
> channels, and the other one can provide 8 channels. Should I use the
> property name of 'jh8100,i2s-max-channels' instead for some special
> instances on the JH8100 SoC?

No, your current name is fine if the binding is generic for all Cadence
users.  I do think it would be good to have a separate compatible for
these two channel instances, if there's been one customisation there may
well have been others.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Attachment: signature.asc
Description: PGP signature