Re: [PATCH 2/4] reset: add GPIO-based reset controller

From: Krzysztof Kozlowski
Date: Fri Dec 22 2023 - 10:09:42 EST


On 22/12/2023 16:01, Krzysztof Kozlowski wrote:
> Add simple driver to control GPIO-based resets using the reset
> controller API for the cases when the GPIOs are shared and reset should
> be coordinated. The driver is expected to be used by reset core
> framework for ad-hoc reset controllers.

...

> +
> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> +
> + platform_set_drvdata(pdev, &priv->rc);
> + device_set_node(dev, of_fwnode_handle(*platdata));
> +
> + /*
> + * Need to get non-exclusive because it is used in reset core as cookie
> + * to find existing controllers. However the actual use is exclusive.
> + */

This comment is a left-over of my work-in-progress and it is not
accurate anymore. Exclusive GPIOs are not used, which should make
Bartosz happy!

I will remove it in v2.


Best regards,
Krzysztof