Re: [net-next PATCH v4 1/4] dt-bindings: net: phy: Document new LEDs polarity property

[Conor Dooley]

On Thu, Dec 21, 2023 at 10:43:17AM +0100, Andrew Lunn wrote:
> > On the marvell10g series we are discussing of using tristate or not. We
> > notice tristate might be confusing, would it be better to use
> > inactive-high-impedance ?
> 
> The pincfg-node.yaml binding has:
> 
>   drive-open-drain:
>     oneOf:
>       - type: boolean
>       - $ref: /schemas/types.yaml#/definitions/uint32
>         const: 1    # No known cases of 0
>         deprecated: true
>     description: drive with open drain
> 
>   drive-open-source:
>     type: boolean
>     description: drive with open source
> 
> I'm not sure what the deprecated means. Is it that a value is
> deprecated, not the property as a whole?

Yeah, it means that only the boolean form of this property should be
used going forward.

The comment suggests that the value had no meaning in the first place,
and that testing for presence alone has been sufficient all along.

Attachment: signature.asc
Description: PGP signature