Re: [PATCH v3] tracing/selftests: Add ownership modification tests for eventfs

From: Shuah Khan
Date: Fri Dec 22 2023 - 11:15:54 EST


On 12/21/23 19:16, Steven Rostedt wrote:

Shuah,

This patch has no dependencies. You can take it through your tree for the
next merge window if you want. If not, I can take it.

Tried to apply this and seeing a couple of issues:

-- missing SPDX
-- this file has executable permission set unlike the existing
.tc files in the same directory

ERROR: do not set execute permissions for source files
#72: FILE: tools/testing/selftests/ftrace/test.d/00basic/test_ownership.tc

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#72:
new file mode 100755

WARNING: Missing or malformed SPDX-License-Identifier tag in line 2
#78: FILE: tools/testing/selftests/ftrace/test.d/00basic/test_ownership.tc:2:
+# description: Test file and directory owership changes for eventfs

total: 1 errors, 2 warnings, 113 lines checked

thanks,
-- Shuah