Re: [PATCH v4] tracing/selftests: Add ownership modification tests for eventfs

From: Shuah Khan
Date: Fri Dec 22 2023 - 12:03:33 EST


On 12/22/23 09:34, Steven Rostedt wrote:
From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>

As there were bugs found with the ownership of eventfs dynamic file
creation. Add a test to test it.

It will remount tracefs with a different gid and check the ownership of
the eventfs directory, as well as the system and event directories. It
will also check the event file directories.

It then does a chgrp on each of these as well to see if they all get
updated as expected.

Then it remounts the tracefs file system back to the original group and
makes sure that all the updated files and directories were reset back to
the original ownership.

It does the same for instances that change the ownership of he instance
directory.

Note, because the uid is not reset by a remount, it is tested for every
file by switching it to a new owner and then back again.

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
Tested-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
---
Changes since v3: https://lore.kernel.org/linux-trace-kernel/20231221211229.13398ef3@xxxxxxxxxxxxxxxxxx

- Added missing SPDX and removed exec permission from file (Shuah Khan)


Thank you. Applied to linux-kselftest next branch for Linux 6.8-rc1

thanks,
-- Shuah