Re: [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml

[Krzysztof Kozlowski]

On 25/12/2023 06:39, Shenghao Ding wrote:
> Move tas2563 from tas2562.yaml to tas2781.yaml, because tas2563 only work
> in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for
> tas2563, it has been moved to tas2781 driver. As to the hardware part,
> such as register setting and DSP firmware, all these are stored in the
> binary firmware. What tas2781 drivder dooes is to parse the firmware and
> download them to the tas2781 or tas2563, then power on tas2781 or tas2563.
> So, tas2781 driver can be resued as tas2563 driver。 Only attention will
> be paid to downloading corresponding firmware.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@xxxxxx>
> 
> ---
> Change in v3:
>  - remove tas2563, which will be move to tas2781 driver
>  - Add more comments on why move tas2563 to tas2781 driver
>  - provide rationale in terms of bindings and hardware, not in terms of driver.
>    Or at least not only.

How did you implement my comment about squashing?

If you decided not to implement it, why not dropping a note?

Best regards,
Krzysztof