Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx

From: Andy Shevchenko
Date: Wed Dec 27 2023 - 12:40:55 EST



On Sat, Dec 23, 2023 at 01:06:04PM +0300, Nikita Shubin wrote:
> On Wed, 2023-12-13 at 20:37 +0200, Andy Shevchenko wrote:
> > On Tue, Dec 12, 2023 at 11:20:25AM +0300, Nikita Shubin wrote:

...

> > > +       dev_info(dev, "EP93xx SoC revision %s\n", attrs->revision);
> >
> > Hmm... Is this message anyhow useful?
>
> Can we keep it please ? It makes us happy when we see it in logs for
> historical reasons - it's been there since 2.4.

Maybe it's good to add in the comment area / cover letter why this is useful.

--
With Best Regards,
Andy Shevchenko