Re: [PATCH V8 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

From: Jack Chang
Date: Fri Dec 29 2023 - 04:18:56 EST


On 2023/12/28 23:28, Krzysztof Kozlowski wrote:
> On 28/12/2023 16:15, larry.lai wrote:
>> The UP Squared board <http://www.upboard.com> implements certain
>> features (pin control) through an on-board FPGA.

...

>> +MODULE_ALIAS("platform:upboard-pinctrl");
>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.

add "platform:" for auto probe these two drivers when upboard-fpga
has probe and register these 2 drivers.

--
Best Regards,
Jack Chang