Re: [PATCH 2/2] virtiofs: Improve error handling in virtio_fs_get_tree()

From: Matthew Wilcox
Date: Fri Dec 29 2023 - 09:22:07 EST


On Fri, Dec 29, 2023 at 10:10:08AM +0100, Markus Elfring wrote:
> >> The kfree() function was called in two cases by
> >> the virtio_fs_get_tree() function during error handling
> >> even if the passed variable contained a null pointer.
> >
> > So what? kfree(NULL) is perfectly acceptable.
>
> I suggest to reconsider the usefulness of such a special function call.

Can you be more explicit in your suggestion?