Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for a HP ZBook

[Andy Chi]

Hi Geraldo,
Yes, this model is not yet publicly available, so I can't type the
full name on this patch.

(change to text plain mode to send out again.)

Kr,
Andy


On Tue, Jan 2, 2024 at 1:47 PM Andy Chi <andy.chi@xxxxxxxxxxxxx> wrote:
>
> Hi Geraldo,
> Yes, this model is not yet publicly available, so I can't type the full name on this patch.
>
> Kr,
> Andy
>
> On Tue, Jan 2, 2024 at 12:25 PM Geraldo Nascimento <geraldogabriel@xxxxxxxxx> wrote:
>>
>> On Tue, Jan 02, 2024 at 10:49:15AM +0800, Andy Chi wrote:
>> > There is a HP ZBook which using ALC236 codec and need the
>> > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED
>> > and micmute LED work.
>>
>> Hi Andy,
>>
>> I know Takashi in the name of smooth operation usually takes this kind
>> of simple patch, quickly, since it's a simple bugfix, unless there are
>> any objections, so I must raise one.
>>
>> Which HP ZBook? Which model?
>>
>> Is this a still unreleased model Canonical has had access under a NDA
>> for example? Or perhaps there is some other reason why you cannot name
>> the model yet?
>>
>> Either way, there is a need to publicly know the reason for the missing
>> model information.
>>
>> >
>> > Signed-off-by: Andy Chi <andy.chi@xxxxxxxxxxxxx>
>> > ---
>> >  sound/pci/hda/patch_realtek.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> > index 7e9d8c1cedfc..1c8d5b58eb64 100644
>> > --- a/sound/pci/hda/patch_realtek.c
>> > +++ b/sound/pci/hda/patch_realtek.c
>> > @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>> >       SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
>> >       SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
>> >       SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
>> > +     SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>>
>> Same questioning as above. "HP" is IMHO unacceptable without a clear
>> reason for the missing model information.
>>
>> Thanks,
>> Geraldo Nascimento
>>
>> >       SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>> >       SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>> >       SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
>> > --
>> > 2.34.1
>> >
>> >