Re: [PATCH v4 7/7] cxl/memdev: Register for and process CPER events

[Jonathan Cameron]

On Tue, 19 Dec 2023 16:29:08 -0800
Ira Weiny <ira.weiny@xxxxxxxxx> wrote:

> Dan Williams wrote:
> > Ira Weiny wrote:
> > [..]  
> > > > and drop the = NULL above.  
> > > 
> > > Done.  
> > 
> > The NULL assignment was more about making it clear that
> > __free(pci_dev_put) will take no action until the pdev is acquired.
> > Otherwise, any future refactoring that introduces a 'return' before
> > @pdev is acquired needs to be careful to assign @pdev to NULL. So, just
> > include it in the declaration more as a __free() declaration style issue
> > than a correctness issue.  
> 
> I think he meant the assignment to cxlds.  At least that is the NULL
> assignment I took out.
> 
> Ira

yup.  The other one is correct as Dan pointed out.