Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

[Daniel Díaz]

Hello!

On 03/01/24 10:10 p. m., Daniel Díaz wrote:
> Hello!
>
> On 03/01/24 10:55 a. m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.6.10 release.
> > There are 49 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> > or in the git tree and branch at:
> >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> We're seeing a build regression with x86/GCC-8 and allmodconfig:
>
> -----8<-----
>    In file included from /builds/linux/include/linux/string.h:294,
>                     from /builds/linux/include/linux/bitmap.h:11,
>                     from /builds/linux/include/linux/cpumask.h:12,
>                     from /builds/linux/arch/x86/include/asm/paravirt.h:17,
>                     from /builds/linux/arch/x86/include/asm/cpuid.h:62,
>                     from /builds/linux/arch/x86/include/asm/processor.h:19,
>                     from /builds/linux/arch/x86/include/asm/cpufeature.h:5,
>                     from /builds/linux/arch/x86/include/asm/thread_info.h:53,
>                     from /builds/linux/include/linux/thread_info.h:60,
>                     from /builds/linux/include/linux/uio.h:9,
>                     from /builds/linux/include/linux/socket.h:8,
>                     from /builds/linux/include/uapi/linux/if.h:25,
>                     from /builds/linux/net/wireless/nl80211.c:11:
>    In function 'nl80211_set_cqm_rssi.isra.44',
>        inlined from 'nl80211_set_cqm' at /builds/linux/net/wireless/nl80211.c:13000:10:
>    /builds/linux/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' pointer overflow between offset 36 and size [-1, 9223372036854775807] [-Werror=array-bounds]
>     #define __underlying_memcpy __builtin_memcpy
>                                 ^
>    /builds/linux/include/linux/fortify-string.h:648:2: note: in expansion of macro '__underlying_memcpy'
>      __underlying_##op(p, q, __fortify_size);   \
>      ^~~~~~~~~~~~~
>    /builds/linux/include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk'
>     #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,   \
>                              ^~~~~~~~~~~~~~~~~~~~
>    /builds/linux/net/wireless/nl80211.c:12939:3: note: in expansion of macro 'memcpy'
>       memcpy(cqm_config->rssi_thresholds, thresholds,
>       ^~~~~~
>    cc1: all warnings being treated as errors
>    make[5]: *** [/builds/linux/scripts/Makefile.build:243: net/wireless/nl80211.o] Error 1
> ----->8-----
>
> This is currently being bisected, so there is more to follow.

Bisection pointed to:

  commit 92045aab1bd9bfd73d816e907ea07739c4550b41
  Author: Johannes Berg <johannes.berg@xxxxxxxxx>
  Date:   Sat Dec 16 05:47:15 2023 +0000

      wifi: cfg80211: fix CQM for non-range use
      
      commit 7e7efdda6adb385fbdfd6f819d76bc68c923c394 upstream.

Reverting that was not possible, so I reverted 47f3694a4259 first ("wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)"), but that was not enough. After reverting both 47f3694a4259 and 92045aab1bd9, the build passed again.

Reproducer:

  tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-8 --kconfig allmodconfig


Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx